fix: preserve scrollback for top-anchored regions#180
Merged
nick-skriabin merged 1 commit intosemos-labs:mainfrom Mar 28, 2026
Merged
fix: preserve scrollback for top-anchored regions#180nick-skriabin merged 1 commit intosemos-labs:mainfrom
nick-skriabin merged 1 commit intosemos-labs:mainfrom
Conversation
Contributor
|
@W25X80 thank you for the PR. i will review and manually test it before moving forward |
nick-skriabin
approved these changes
Mar 28, 2026
Contributor
nick-skriabin
left a comment
nick-skriabin
left a comment
There was a problem hiding this comment.
please, add a description of the user-facing bug that you fixed. other than that PR looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This routes LF/index and CSI S through a shared top-anchored path and adds regression coverage for DECSTBM cases, mixed transcripts, viewport coupling and zero-scrollback behavior.
Use case: some CLIs like Codex render in the primary screen with a fixed footer or prompt area and only scroll the top region instead of switching to thealternate screen. Before this change, lines pushed out of that region were not preserved in scrollback, so users could not scroll back through output in those sessions.
With this fix, that history is preserved, so normal terminal scrollback works as expected for these inline TUI-style workflows while keeping non-top-anchored and alt-screen behavior unchanged.