This repository was archived by the owner on Aug 30, 2022. It is now read-only.
Send full reducer payload to OpenChannel start msg #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the work done on this library!
Motivation
The motivation behind this PR was a possible bug that I found when trying to customize the
UIKIT=>OpenChannelviarenderMessageInput. There's no UIKIT documentation specifically forOpenChannelrenderMessageInput, so I dig into the code and I also compared with the existing documentation for the samerenderMessageInputbut for the `GroupChannel. With these findings I could get to a code similar to this one:With this code I could render my Chat just fine and I could also send the message, but as soon as the send happens, something in UIKIT calls a re-render and this was causing the following error:
I dig into the code again and I found that there's a single occurrence of
SENDING_MESSAGE_STARTthat was being sent without thechannelas part of the payload. This way this PR is to fix this reduce action to send the same payload as it's being already sent by other places in the code that dispatches the same action.Please let me know if this is enough info.
Changes