Skip to content

fix/mark-as-unread-qa #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: feat/mark-as-unread
Choose a base branch
from

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Jul 10, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[TICKET_ID]

Description Of Changes

  • QA 버그 수정
  • NewMessageButton, UnreadMessageFloating에서 카운트가 100이상일경우 99+ 로 표시하도록 수정

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 11.25%. Comparing base (9650e6a) to head (0108698).

Files with missing lines Patch % Lines
...groupChannel/component/GroupChannelMessageList.tsx 0.00% 17 Missing ⚠️
...act-native/src/localization/createBaseStringSet.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feat/mark-as-unread     #248      +/-   ##
=======================================================
- Coverage                11.27%   11.25%   -0.03%     
=======================================================
  Files                      360      360              
  Lines                     8653     8672      +19     
  Branches                  2454     2463       +9     
=======================================================
  Hits                       976      976              
- Misses                    7601     7620      +19     
  Partials                    76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee requested review from bang9 and Copilot July 10, 2025 01:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes QA bugs related to unread/new message indicators by capping counts at “99+” and refines the mark-as-unread floating indicator behavior.

  • Updates localization strings to display “99+” when counts ≥ 100 for both new and unread message labels.
  • Enhances GroupChannelMessageList to track scroll position and viewable messages for better mark-as-unread logic.
  • Removes a fixed height from the new-line renderer container to let its content size naturally.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/uikit-react-native/src/localization/createBaseStringSet.ts Capped message counts at 99+ and refactored singular/plural logic.
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx Added refs and effects to track unread state and scroll events.
packages/uikit-react-native/src/components/GroupChannelMessageRenderer/GroupChannelMessageNewLine.tsx Removed hardcoded container height.
Comments suppressed due to low confidence (2)

packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx:37

  • [nitpick] The name isNewLineExistInChannelRef is awkward; consider renaming it to hasNewLineInChannelRef for clearer boolean semantics.
  const isNewLineExistInChannelRef = useRef(false);

packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx:235

  • viewableMessages.current is never set before this effect, so isNewLineExistInChannelRef will remain false. Ensure you populate viewableMessages.current (e.g., in an onViewableItemsChanged callback) before relying on it.
    isNewLineExistInChannelRef.current = !!props.isNewLineExistInChannel && !!viewableMessages.current;

@OnestarLee OnestarLee removed the request for review from bang9 July 14, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants