-
Notifications
You must be signed in to change notification settings - Fork 45
fix/mark-as-unread-qa #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/mark-as-unread
Are you sure you want to change the base?
Conversation
…height from GroupChannelMessageNewLine
…hannelMessageList
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/mark-as-unread #248 +/- ##
=======================================================
- Coverage 11.27% 11.25% -0.03%
=======================================================
Files 360 360
Lines 8653 8672 +19
Branches 2454 2463 +9
=======================================================
Hits 976 976
- Misses 7601 7620 +19
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes QA bugs related to unread/new message indicators by capping counts at “99+” and refines the mark-as-unread floating indicator behavior.
- Updates localization strings to display “99+” when counts ≥ 100 for both new and unread message labels.
- Enhances
GroupChannelMessageList
to track scroll position and viewable messages for better mark-as-unread logic. - Removes a fixed height from the new-line renderer container to let its content size naturally.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
packages/uikit-react-native/src/localization/createBaseStringSet.ts | Capped message counts at 99+ and refactored singular/plural logic. |
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx | Added refs and effects to track unread state and scroll events. |
packages/uikit-react-native/src/components/GroupChannelMessageRenderer/GroupChannelMessageNewLine.tsx | Removed hardcoded container height. |
Comments suppressed due to low confidence (2)
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx:37
- [nitpick] The name
isNewLineExistInChannelRef
is awkward; consider renaming it tohasNewLineInChannelRef
for clearer boolean semantics.
const isNewLineExistInChannelRef = useRef(false);
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx:235
viewableMessages.current
is never set before this effect, soisNewLineExistInChannelRef
will remain false. Ensure you populateviewableMessages.current
(e.g., in an onViewableItemsChanged callback) before relying on it.
isNewLineExistInChannelRef.current = !!props.isNewLineExistInChannel && !!viewableMessages.current;
packages/uikit-react-native/src/localization/createBaseStringSet.ts
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx
Outdated
Show resolved
Hide resolved
…et.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…mark-as-unread-qa
… resource references
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[TICKET_ID]
Description Of Changes
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_