Skip to content

fix: frozen string literal issue for ruby 3.4.0 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manisha1997 merged 5 commits into from
Nov 25, 2025
Merged

fix: frozen string literal issue for ruby 3.4.0 #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8ae5d6
Fix frozen string literal issue
chaadow Nov 17, 2024
7689f47
Add empty line for code readability
manisha1997 Nov 10, 2025
b12f495
Remove extra newline at end of ruby_http_client.rb
tiwarishubham635 Nov 14, 2025
d897823
Fix YAML syntax for Ruby version matrix
manisha1997 Nov 14, 2025
2434846
Update copyright year in LICENSE file
manisha1997 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', '3.1', 'jruby-9.2' ]
ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0', '3.1' ]
steps:
- name: Checkout ruby-http-client
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (C) 2023, Twilio SendGrid, Inc. <help@twilio.com>
Copyright (C) 2025, Twilio SendGrid, Inc. <help@twilio.com>

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
Expand Down
2 changes: 1 addition & 1 deletion lib/ruby_http_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def build_args(args)
# - The final url string
#
def build_url(query_params: nil)
url = [add_version(''), *@url_path].join('/')
url = [add_version(+''), *@url_path].join('/')
url = build_query_params(url, query_params) if query_params
URI.parse("#{@host}#{url}")
end
Expand Down