Updated depreciated np.int too np.int_#15
Open
sw241395 wants to merge 3 commits intoseninp:masterfrom
Open
Conversation
Author
|
I was planning on implementing the ability to have more than 26 number of cuts for SAX but am limited as the output of the method is string and it may get confusing between a SAX representation of ['a', 'a', 'b', 'a'] and ['a', 'ab', 'a']. You could change it so that you return a list of strings rather than a single string, therefore you are not limited too 26 cuts. |
m0odero
reviewed
May 24, 2023
m0odero
left a comment
m0odero
left a comment
There was a problem hiding this comment.
Is it possible to accelerate the merging of this change so we can effectively use it? It's currently throwing errors and it's impossible to move on without this. I would also suggest that we use int64/int32 instead of int_
Author
|
Have updated int_ too int64, is this ok? |
This is okay. I'll test and revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still new to contributing to open source, if you want me to make any edits to this PR then feel free to let me know.