Conversation
…chain.com scan.sentrixchain.com remains the primary explorer with full native-op coverage. Blockscout sidecar adds EVM-standard UX (ERC-20 holders, source verification, EIP-3091 URLs) for listing platforms + EVM tooling that expects that shape.
engine.rs was 2166 LOC mixing five concerns:
- timeout constants + propose/prevote/precommit_timeout helpers
- BftPhase enum
- BftRoundState struct + impl (per-(height,round) bookkeeping)
- VoteCollector struct + impl (stake-weighted tally + supermajority)
- the BftEngine itself + tests
Moved the first three into engine/{timeouts,state,vote_collector}.rs
and re-export from engine.rs so the public API at sentrix_bft::engine::*
is unchanged. engine.rs drops to 1944 LOC, focused on BftEngine.
No behaviour change. cargo clippy --workspace --tests -- -D warnings
clean; cargo test --workspace passes; live verified on mainnet 7119
(halt-all + simul-start, all 4 validators advancing 4-of-4 lockstep)
+ testnet 7120 (4 docker validators advancing).
Phase 3 of the workspace audit.
1 task
satyakwok
added a commit
that referenced
this pull request
Apr 29, 2026
* docs: dual-explorer note for Blockscout sidecar at blockscout.sentrixchain.com scan.sentrixchain.com remains the primary explorer with full native-op coverage. Blockscout sidecar adds EVM-standard UX (ERC-20 holders, source verification, EIP-3091 URLs) for listing platforms + EVM tooling that expects that shape. * chore: humanize the just-extracted submodule headers The recent batch of refactor PRs (#419 explorer, #420 bft engine, #421 slashing) shipped with header comments that read a bit like a release- notes generator wrote them — "X.rs — short description. Pulled out of Y for Z. No behaviour change." That's not the voice the rest of this codebase carries. Comments here usually tell stories, reference incidents, drop dates and PR numbers. This pass rewrites the seven new file headers + the two re-export blocks so they sound like the operator wrote them late at night, which is closer to the truth. No code change. --------- Co-authored-by: Satya Kwok <satyakwik@gmail.com> Co-authored-by: satyakwok <satyakwok@users.noreply.github.com> Co-authored-by: Satya Kwok <satyakwik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 (consensus-touching) of the workspace audit.
bft/engine.rswas 2166 LOC mixing five concerns:PROPOSE_TIMEOUT_MS/PREVOTE_TIMEOUT_MS/PRECOMMIT_TIMEOUT_MS/ etc.) + helpers (propose_timeout/prevote_timeout/precommit_timeout)BftPhaseenumBftRoundStatestruct + impl (per-(height, round) bookkeeping with locked-block / staging-block fields)VoteCollectorstruct + impl (stake-weighted prevote + precommit tally with supermajority detection)BftEngineitself + testsMoved the first three into
engine/{timeouts,state,vote_collector}.rsand re-exported fromengine.rsso the public API atsentrix_bft::engine::*(and the lib.rs re-exports) is unchanged.engine.rsdrops to 1944 LOC, focused onBftEngineitself.No behaviour change. Pure mechanical extraction.
Test plan
cargo clippy --workspace --tests -- -D warningscleancargo test --workspacepasses (700+ tests, 0 failures)