Skip to content

feat: add ability to set .spec.strategy for sentry-web, snuba-api and symbo… #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+27 −3
Open

feat: add ability to set .spec.strategy for sentry-web, snuba-api and symbo… #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sentry/templates/deployment-sentry-web.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ metadata:
heritage: "{{ .Release.Service }}"
spec:
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
strategy:
type: {{ .Values.sentry.web.strategyType }}
selector:
matchLabels:
app: {{ template "sentry.fullname" . }}
release: "{{ .Release.Name }}"
role: web
{{- if .Values.sentry.web.updateStrategy }}
strategy:
{{ toYaml .Values.sentry.web.updateStrategy | nindent 4 }}
{{- end }}
{{- if not .Values.sentry.web.autoscaling.enabled }}
replicas: {{ .Values.sentry.web.replicas }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions sentry/templates/deployment-snuba-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ spec:
app: {{ template "sentry.fullname" . }}
release: "{{ .Release.Name }}"
role: snuba-api
{{- if .Values.snuba.api.updateStrategy }}
strategy:
{{ toYaml .Values.snuba.api.updateStrategy | nindent 4 }}
{{- end }}
{{- if not .Values.snuba.api.autoscaling.enabled }}
replicas: {{ .Values.snuba.api.replicas }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions sentry/templates/deployment-symbolicator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ spec:
app: {{ template "sentry.fullname" . }}
release: "{{ .Release.Name }}"
role: symbolicator-api
{{- if .Values.symbolicator.api.updateStrategy }}
strategy:
{{ toYaml .Values.symbolicator.api.updateStrategy | nindent 4 }}
{{- end }}
{{- if not .Values.symbolicator.api.autoscaling.enabled }}
replicas: {{ .Values.symbolicator.api.replicas }}
{{- end }}
Expand Down
16 changes: 15 additions & 1 deletion sentry/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,11 @@ sentry:
web:
enabled: true
# if using filestore backend filesystem with RWO access, set strategyType to Recreate
strategyType: RollingUpdate
updateStrategy:
type: RollingUpdate
# rollingUpdate:
# maxSurge: 1
# maxUnavailable: 0
replicas: 1
env: []
probeFailureThreshold: 5
Expand Down Expand Up @@ -805,6 +809,11 @@ sentry:
snuba:
api:
enabled: true
updateStrategy:
type: RollingUpdate
# rollingUpdate:
# maxSurge: 1
# maxUnavailable: 0
replicas: 1
# set command to ["snuba","api"] if securityContext.runAsUser > 0
# see: https://github.com/getsentry/snuba/issues/956
Expand Down Expand Up @@ -1492,6 +1501,11 @@ symbolicator:
enabled: false
api:
replicas: 1
updateStrategy:
type: RollingUpdate
# rollingUpdate:
# maxSurge: 1
# maxUnavailable: 0
env: []
probeInitialDelaySeconds: 10
resources: {}
Expand Down