Fix incorrect unpacking of job data#82
Open
hamishforbes wants to merge 1 commit intoseomoz:masterfrom
Open
Conversation
|
I believe |
Author
|
Oh I see, sorry that's my bad. I looked at that and though it was indexing the return from The variable is still unused in the first change (state) but looks like the worker one should be broken. edit: I think actually the errors we were seeing were caused by a too-small Redis memory limit causing evictions in the middle of job processing |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 2 cases where job data fields (state and worker) are passed to
unpackeven though they are strings.The first case (state), the variable was unused anyway so I just removed it totally.