Save job data as-is without re-encoding#83
Open
NathanBaulch wants to merge 2 commits intoseomoz:masterfrom
Open
Save job data as-is without re-encoding#83NathanBaulch wants to merge 2 commits intoseomoz:masterfrom
NathanBaulch wants to merge 2 commits intoseomoz:masterfrom
Conversation
|
I don't see the checks run on this PR, but the content looks good to me |
Author
|
Any idea why Travis didn't kick off? |
|
I don't :-/ I no longer have access to the Travis configuration. @lindseyreno or @evanbattaglia - do you happen to know? |
|
I don't know how or why but the repo was deactivated in Travis. I reactivated it and it is working again. Either reopen the PR or push an empty commit to trigger a build. |
|
LGTM |
Author
|
Bump! |
1 similar comment
Author
|
Bump! |
Contributor
|
See my comment on #85 regarding the state of this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cjsonescapes forward slashes which is causing problems for me. I'd like qless to just save job data to Redis verbatim without any decode/encode side-effects.I've also fixed some inconsistencies with job data param names and assertion messages.
All unit tests are passing.