Externalize lib-pairing module to libseqera#958
Open
pditommaso wants to merge 5 commits intomasterfrom
Open
Conversation
- Create lib-pairing Gradle submodule for credential federation functionality - Move pairing service, WebSocket transport, and message types to new module - Extract configuration into PairingConfig interface with implementation in Wave - Create LicenseValidator interface for decoupling license validation - Rename package from io.seqera.wave.service.pairing to io.seqera.service.pairing - Update all Wave imports to reference the new library package The lib-pairing module provides: - RSA key pair generation and caching for secure credential sharing - WebSocket-based bidirectional communication for real-time messaging - HTTP request/response proxying over WebSocket connections - Distributed state management via Redis-backed stores Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add PairingMessageEncodeStrategyTest: polymorphic message encoding/decoding - Add PairingRecordSerializationTest: record serialization with Moshi - Add PairingExchangeSerializationTest: request/response model tests - Use Spock 'where:' clauses for data-driven tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Move the lib-pairing subproject out of Wave and consume it as an external dependency from libseqera. This eliminates the wave-utils dependency by inlining the MD5 logic into a new CacheKey utility class. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pditommaso
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the pairing service out of Wave into libseqera/lib-pairing and consumes it as an external dependency.
io.seqera.wave.service.pairinginto a standalonelib-pairingmodule (now hosted in libseqera)CacheKeyutility class to eliminate thewave-utilsdependency, making lib-pairing fully self-containedio.seqera:lib-pairing:1.0.0as an external dependency instead of a subprojectTest plan
./gradlew :lib-pairing:buildpasses in libseqera (28 tests)./gradlew :test --tests '*Pairing*'passes in Wave withincludeBuild('../libseqera')🤖 Generated with Claude Code