ruby upgrade & style upgrade & performance improvements#7
Open
isimluk wants to merge 16 commits intosergey-chechaev:masterfrom
Open
ruby upgrade & style upgrade & performance improvements#7isimluk wants to merge 16 commits intosergey-chechaev:masterfrom
isimluk wants to merge 16 commits intosergey-chechaev:masterfrom
Conversation
This may have beneficial perf impact and
else next
branch makes sure not to duplicate dates in sequence of multiple dates, and datetimes
Owner
sergey-chechaev
left a comment
sergey-chechaev
left a comment
There was a problem hiding this comment.
Nice, can you squash commits?
Author
|
Would you mind squashing at the merge?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank You for sharing this library. I played with it a little bit and here are a couple of changes that I would propose.