Skip to content

Conversation

@cole-h
Copy link

@cole-h cole-h commented Dec 6, 2025

Closes #250.

&deploy::LoggerType::Deploy,
)?;

if opts.dry_activate && opts.boot {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was intentionally not handled in clap; if so, I can revert that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good change. I prefer the solution you are taking.

@cole-h cole-h mentioned this pull request Dec 6, 2025
@weriomat
Copy link
Contributor

weriomat commented Dec 6, 2025

Could you update the interface.json please?

@cole-h
Copy link
Author

cole-h commented Dec 7, 2025

@weriomat Sorry, could you be more specific on what I need to update? I took a look at interface.json and it doesn't seem to have anything related to boot or dry-activate for me to base my addition for test on.

Copy link
Contributor

@weriomat weriomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon me, I forgot that the interface.json is only applicable for configuration specifiable in the .#deploy output of the flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --test flag

2 participants