Skip to content

feat: Adding support for failure policy #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Adding support for failure policy #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6d06b5
Adding support for failure policy
Nov 2, 2018
5756efe
Merge branch 'master' into master
patrickhousley Feb 26, 2020
7445c93
Merge branch 'master' into master
patrickhousley Mar 14, 2020
8cbb32a
Merge branch 'master' into master
patrickhousley Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package/lib/compileFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,13 @@ module.exports = {
const type = funcObject.events[0].event.eventType;
const path = funcObject.events[0].event.path; //eslint-disable-line
const resource = funcObject.events[0].event.resource;
const failurePolicy = funcObject.events[0].event.failurePolicy;

funcTemplate.properties.eventTrigger = {};
funcTemplate.properties.eventTrigger.eventType = type;
if (path) funcTemplate.properties.eventTrigger.path = path;
funcTemplate.properties.eventTrigger.resource = resource;
if (failurePolicy) funcTemplate.properties.eventTrigger.failurePolicy = failurePolicy;
}

this.serverless.service.provider.compiledConfigurationTemplate.resources.push(funcTemplate);
Expand Down
34 changes: 34 additions & 0 deletions package/lib/compileFunctions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,20 @@ describe('CompileFunctions', () => {
},
],
},
func3: {
handler: 'func3',
events: [
{
event: {
eventType: 'foo',
resource: 'some-resource',
failurePolicy: {
retry: {},
},
},
},
],
},
};

const compiledResources = [
Expand Down Expand Up @@ -608,6 +622,26 @@ describe('CompileFunctions', () => {
labels: {},
},
},
{
type: 'cloudfunctions.v1beta2.function',
name: 'my-service-dev-func3',
properties: {
location: 'us-central1',
runtime: 'nodejs8',
function: 'func3',
availableMemoryMb: 256,
timeout: '60s',
sourceArchiveUrl: 'gs://sls-my-service-dev-12345678/some-path/artifact.zip',
eventTrigger: {
eventType: 'foo',
resource: 'some-resource',
failurePolicy: {
retry: {},
},
},
labels: {},
},
},
];

return googlePackage.compileFunctions().then(() => {
Expand Down