Do not generate SSL if DISABLE_DEFAULT_CONFIG is set #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add checks for DISABLE_DEFAULT_CONFIG and set default SSL file paths.
jaydrogers
changed the title
jaydrogers
changed the base branch from
main
to
release/webserver-improvements-and-fixes
jaydrogers
merged commit 9ad2270
into
serversideup:release/webserver-improvements-and-fixes
83 checks passed
github-project-automation
bot
moved this from In progress
to Done
in serversideup/php: 4.4 Release
Member
|
Thanks for this, great catch! This will be made available in the next release 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks for DISABLE_DEFAULT_CONFIG and set default SSL file paths.