MSVC: Avoid unknown option -std:c++11 build warning #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
msvc-build-warning
branch
from
6ac6aad to
0905b71
Compare
mrobinson
approved these changes
Jun 21, 2025
MSVC does not offer a C++11 mode, so passing the flag triggers an unknown flag warning. ``` warning: fontsan@0.6.0: cl : Command line warning D9002 : ignoring unknown option '-std:c++11' ```
jschwe
force-pushed
the
msvc-build-warning
branch
from
0905b71 to
e6fb9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC doesn't support C++11 and defaults to C++14, so we just don't set a flag for MSVC.
The upstream build systems for Woff2 uses C++11 as well as ots.
Note: This PR is based on #39, so only need to review the last commit.