Draft
Conversation
gw3583
approved these changes
May 10, 2020
Contributor
gw3583
left a comment
gw3583
left a comment
There was a problem hiding this comment.
LGTM, apart from those couple comments.
|
|
||
| [build-dependencies] | ||
| gl_generator = "0.14" | ||
| #gl_generator = "0.14" |
Contributor
There was a problem hiding this comment.
Reminder to remove this before merging, once upstream is published
| @@ -9,4 +9,5 @@ repository = "https://github.com/servo/gleam" | |||
| description = "Generated OpenGL bindings and wrapper for Servo." | |||
Contributor
There was a problem hiding this comment.
We will need to bump the version number.
Contributor
|
☔ The latest upstream changes (presumably #215) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on rust-windowing/gl-rs#518 being merged and published.
Can still be reviewed in the meantime!