Work around ANGLE bug in glGetDebugMessageLog#233
Merged
emilio merged 2 commits intoservo:mainfrom Jun 17, 2025
Merged
Conversation
ANGLE can return one more message than specified by the provided count argument. This results in an out of bounds panic in gleam. https://issues.angleproject.org/issues/425579207 To avoid this, ensure the provided buffers are one larger than the requested count. As an additional precaution, stop blindly trusting that the returned count is smaller to or equal than the buffers' capacities.
emilio
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANGLE has a bug where it may return one too many messages from glGetDebugMessageLog.
Reported upstream here: https://issues.angleproject.org/issues/425579207
To avoid this, ensure the buffers we provide to the function have a capacity one greater than the count we provide. This shouldn't have any negative effect on other drivers, so I think it's okay to apply this workaround universally.