Skip to content

Conversation

dawnofmidnight
Copy link
Contributor

The referenced unused variant seems to have been removed in commit 52d736e with the move to #[non_exhaustive].

The referenced unused variant seems to have been removed in commit
52d736e with the move to `#[non_exhaustive]`.
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@43f47e2). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage        ?   82.56%           
=======================================
  Files           ?       24           
  Lines           ?     4244           
  Branches        ?        0           
=======================================
  Hits            ?     3504           
  Misses          ?      740           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dawnofmidnight
Copy link
Contributor Author

Hi! I see that there's some sort of test failure to do with sanitizers, but I don't think that has anything to do the changes in this PR. I can't imagine why this error (repeated several times) would be related to this trivial docs change:

error: mixing `-Zsanitizer` will cause an ABI mismatch in crate `data_url`
  |
  = help: the `-Zsanitizer` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely
  = note: unset `-Zsanitizer` in this crate is incompatible with `-Zsanitizer=thread` in dependency `core`
  = help: set `-Zsanitizer=thread` in this crate or unset `-Zsanitizer` in `core`
  = help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=sanitizer` to silence this error

Given that this is a nightly-only error, I assume this is an issue with CI configuration? I suspect it's appearing now as a result of rust-lang/rust#138736.

@Manishearth Manishearth added this pull request to the merge queue Sep 8, 2025
@Manishearth
Copy link
Member

Yes. I don't recall if that test blocks the merge queue, but we may need to fix it before being able to land this.

Merged via the queue into servo:main with commit 0afccc9 Sep 8, 2025
16 of 18 checks passed
@dawnofmidnight dawnofmidnight deleted the parseerror-docs branch September 10, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants