libsession SNS resolution; add different "connected" states #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for SNS resolution. In doing so, I ran into a problem where the `on_connected` callback would fire before we can actually resolve anything through SNS, and so this also splits the "connected" status into two different concepts: "edge connected" (which is what was there already), and a new concept of "path connected", which means "edge connected" *and* an established inbound path. This adds the needed pieces to implement that concept into Router. Updates the libsession-router jank test to support ONS lookups (which also needs the above for the required proper connectivity detection).
tewinget
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for SNS resolution.
In doing so, I ran into a problem where the
on_connectedcallback would fire before we can actually resolve anything through SNS, and so this also splits the "connected" status into two different concepts: "edge connected" (which is what was there already), and a new concept of "path connected", which means "edge connected" and an established inbound path. This adds the needed pieces to implement that concept into Router.Updates the libsession-router jank test to support ONS lookups (which also needs the above for the required proper connectivity detection).