Fix compile error and host string parsing on macOS#16
Open
turley wants to merge 1 commit intosetmind:masterfrom
Open
Fix compile error and host string parsing on macOS#16turley wants to merge 1 commit intosetmind:masterfrom
turley wants to merge 1 commit intosetmind:masterfrom
Conversation
|
changing this gets me further down the road of compiling, but not past the gate. M4 mac mini. |
Author
|
@chris-l-waters That appears to be the issue described in #12. You might have luck trying the suggestions there, but I got past it by doing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error when compiling under recent versions of macOS (wrong type passed to mkdir).
It also fixes a network connection error that looks like:
The original
substr(target, 0, strchr(target, ':') - target)was causing the host/ip string to be truncated (at least on macOS), so it wasn't able to connect to the actual host.