-
-
Notifications
You must be signed in to change notification settings - Fork 792
Make rust-openssl work with no deprecated symbols #2464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
huwcbjones
wants to merge
44
commits into
sfackler:master
Choose a base branch
from
huwcbjones:huw/non-deprecated
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef2482d
to
9f2bbea
Compare
Let's minimise const cstr declaration boiler-plate
No point creating a new CStr every call
Partially reverts b7495f0 by adding back add_bn and add_utf_string
Simplifies and safens the code
* Serialise the test key in several different formats * Compare serialisation output directly against known good (to prevent regressions) * Rename the test keys to have a consistent naming scheme * Add more deserialisation tests covering different input formats
Co-Authored-By: Samuel Collins <samuel.collins@pexip.com>
Skip doctests for deprecated Sha256 interface and direct users to the EVP_MD interfaces.
The APIs exposed straight up don't exist, and one should use a CipherCtx instead.
9f2bbea
to
0ecf3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: