Merged
Conversation
|
Cursor Agent can help with this pull request. Just |
|
Review changes with |
- Add timezone detection using dayjs timezone plugin - Display user's local timezone abbreviation (e.g., PST, EST) in START/END column - Use yellow color for timezone indicator to distinguish from other column headers - Apply to both table view and verbose VM History view - Show UTC when in UTC timezone, local timezone otherwise Co-authored-by: Daniel Tao <danieltaox@gmail.com>
cursor
bot
force-pushed
the
cursor/start-end-timezone-indicator-0224
branch
from
b57e518 to
f2ad6f1
Compare
Co-authored-by: Daniel Tao <danieltaox@gmail.com>
…eturn value - Moved the getTimezoneAbbreviation function from list.tsx to utils.ts for better modularity. - Updated the function to return null instead of "UTC" when unable to determine the timezone. - Adjusted the display logic in the VM table to conditionally render the timezone abbreviation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add timezone indicators to the "soonest" and "max" column headers in
sf zones lsto clarify the displayed times.The "START/END" columns were interpreted as "soonest" and "max" which represent start times. A
getTimezoneAbbreviation()function was added to detect the user's local timezone (e.g., PST) or default to UTC. The timezone abbreviation is displayed in yellow for better visibility.Slack Thread