Add AES256 support and test vectors#205
Merged
bifurcation merged 2 commits intosframe-wg:mainfrom Sep 18, 2025
Merged
Conversation
bifurcation
approved these changes
Sep 18, 2025
Collaborator
bifurcation
left a comment
There was a problem hiding this comment.
Couple of minor things that I will commit and then merge. I will file a follow-on PR to address some bigger comments:
- This doesn't actually compile, due to a missing
use - I think what we actually want here is an option that will only print the AES-256 test vectors, since that's what you'll want in the AES-256 extension spec. So I'll add command-line arguments to the executable so that by default, it prints the RFC test vectors, and with the option it prints the AES-256 ones. Something like
cargo run --example test_vectors # RFC test vectors
cargo run --example test_vectors --aes256ctr # RFC test vectors + AES-256
cargo run --example test_vectors --aes256ctr --only # Only AES-256
bifurcation
reviewed
Sep 18, 2025
bifurcation
reviewed
Sep 18, 2025
Comment on lines
+237
to
+239
| #[cfg(test)] | ||
| #[generic_tests::define] | ||
| mod test_aes256 { |
Collaborator
There was a problem hiding this comment.
This doesn't need to be in a different module.
Collaborator
|
Also, CI is broken because the i-d-template tools are out of date. Separate issue. |
This was referenced Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the new AES256 SHA512 based cipher suites.