Skip to content

Add AES256 support and test vectors#205

Merged
bifurcation merged 2 commits intosframe-wg:mainfrom
aronrosenberg:add_aes256
Sep 18, 2025
Merged

Add AES256 support and test vectors#205
bifurcation merged 2 commits intosframe-wg:mainfrom
aronrosenberg:add_aes256

Conversation

@aronrosenberg
Copy link
Contributor

@aronrosenberg aronrosenberg commented Sep 18, 2025

Add support for the new AES256 SHA512 based cipher suites.

Copy link
Collaborator

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things that I will commit and then merge. I will file a follow-on PR to address some bigger comments:

  1. This doesn't actually compile, due to a missing use
  2. I think what we actually want here is an option that will only print the AES-256 test vectors, since that's what you'll want in the AES-256 extension spec. So I'll add command-line arguments to the executable so that by default, it prints the RFC test vectors, and with the option it prints the AES-256 ones. Something like
cargo run --example test_vectors # RFC test vectors
cargo run --example test_vectors --aes256ctr # RFC test vectors + AES-256
cargo run --example test_vectors --aes256ctr --only # Only AES-256

Comment on lines +237 to +239
#[cfg(test)]
#[generic_tests::define]
mod test_aes256 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be in a different module.

@bifurcation
Copy link
Collaborator

Also, CI is broken because the i-d-template tools are out of date. Separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants