Skip to content

Conversation

lmmx
Copy link

@lmmx lmmx commented Aug 26, 2025

Hi there, hope this small PR is not overlooking anything: I tried to build the trunk and it failed due to one dependency miss, the rust_decimal import is actually an optional dependency.

The utils function it is used in is only called by code gated by the arrow feature flag, so it is equivalent to feature-gate the util too. I moved the use rust_decimal::Decimal; line down into a direct reference to it in the parameter, to avoid repeating the feature gate directive, and likewise for anyhow::Result (to avoid the unused import warning).

  • It entered the code base 3 months ago here: c7d6ee3

@lmmx lmmx force-pushed the rs-dec-build-fix branch from 9d8549c to 923effd Compare August 26, 2025 12:54
@lmmx
Copy link
Author

lmmx commented Aug 26, 2025

@wangxiaoying
Copy link
Contributor

Thanks @lmmx for contributing! I will close this one for now and redirect to #845 for this change.

@lmmx lmmx deleted the rs-dec-build-fix branch August 26, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants