워크스페이스 채널 목록 조회 API #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into be-feat/ci
ki-met-hoon
reviewed
Jan 23, 2025
Collaborator
ki-met-hoon
left a comment
ki-met-hoon
left a comment
There was a problem hiding this comment.
고생많으셨습니다 👍
리뷰 작성 완료했습니다!
| log.info("Getting channels for workspace with id: {}", workspaceId); | ||
|
|
||
| ChannelListDTO channelListDTO = workSpaceService.getChannels(userId, workspaceId); | ||
| return ResponseEntity.ok().body(channelListDTO); |
Collaborator
There was a problem hiding this comment.
ok method 매개변수로 body값을 넣을 수 있지 않나요?
| @Column(name = "name", length = 100, nullable = false) | ||
| private String name; | ||
|
|
||
| @CreationTimestamp |
Collaborator
There was a problem hiding this comment.
@MappedSuperClass로 항상 사용되는 createdAt, updatedAt , id 변수를 통합시키는건 어떨까요?
| import java.util.Optional; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface UserChannelRepository extends JpaRepository<UserChannel, Long> { |
Collaborator
There was a problem hiding this comment.
ChannelRepository는 @Repository 어노테이션이 있는데 얘는 없는 것 같아요!
|
|
||
| @Repository | ||
| public interface ChannelRepository extends JpaRepository<Channels, Long> { | ||
| List<Channels> findByWorkSpaceWorkspaceId(Long workspaceId); |
Collaborator
There was a problem hiding this comment.
얘는 Optional을 사용하지 않은 이유가 있을까요?
Member
Author
There was a problem hiding this comment.
디폴트 채널이 무조건 있다고 가정했기 때문입니다!
| private final ChannelRepository channelRepository; | ||
| private final UserChannelRepository userChannelRepository; | ||
|
|
||
| public ChannelListDTO getChannels(Long userId, Long workspaceId) { |
Collaborator
There was a problem hiding this comment.
getChannels method가 많은 책임을 가지고 있는 것 같아요! 기능별로 method를 분리하는건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Related issue
#31
Motivation and context
워크스페이스 채널 목록 조회 api 구현
요청 @PathVariable Long workspaceId
응답
public class ChannelListDTO {
private List joinedChannels;
private List unjoinedChannels;
}
public class SimpleChannel {
private Long channelId;
private String channelName;
private LocalDateTime createdAt;
}
Solution
How has this been tested
Types of changes
Checklist