Update requirements.txt - comment unused packages, allow newer versions#4
Open
its-wizza wants to merge 1 commit intosglambert:mainfrom
Open
Update requirements.txt - comment unused packages, allow newer versions#4its-wizza wants to merge 1 commit intosglambert:mainfrom
its-wizza wants to merge 1 commit intosglambert:mainfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble getting the package up and working because my version of Python (3.11) was too new for some of the package versions defined in requirements.txt. I updated the file to allow versions at the defined version or newer and everything I have tested works with the latest versions of these packages. However, not convinced this is best practice for a requirements.txt file.
I also commented out packages I found to be not required for the current features of fitzRoyPy. Maybe there was a reason these were included initially? For example, importlib is not standard lib in Python 3.0, is that why this was originally included?