Sort the 'Available' column for holds as a number instead of a string.#9
Conversation
|
Thanks. Your code works but the sorting is done in a different the way than the plugin handles sorting elsewhere. I'm not sure of the differences between the two methods, but for consistency sake I'd prefer to use the same method everywhere (and the other way also has the advantage of being slightly less code). But I do have a question for you. Where would you expect a suspended hold to appear in the sorted list? Sorting currently ignores the suspended status and uses the estimated wait days which are not actually shown, so you could get sorted list that like this This also happens to be the same way the holds are sorted when you initially open the tab, and sort of makes sense when you think about it, but initially it does look strange. Do you think this is confusing or it is OK? |
|
I had noticed that 'Yes' and 'Never' were getting 0/999999 and would sort fine that way. I did not consider the suspended holds though. I agree, it does look a bit strange at first. Moving them all to the bottom (to just above the 'Never's?) might make someone happy but that does not quite seem right either. |
|
Thanks. I've merged your PR now. I will leave the suspended holds as they are at the moment. |

On the Holds tab clicking the 'Available' header sorts as strings. I have not worked much with Qt but I think this approach makes sense.
Before:
After:
Thanks,
-steve