Conversation
sh0ckR6
added
priority: medium
|
and all of my commits are unverified... might force push and fix that |
|
@gtaEPIC If you don't mind reviewing this PR even though it's been a hot minute, I'd really appreciate it! If not, I can review the PR on my own in the morning and merge it in anyways. I haven't really tested it as it's late, so for all I know it could be hella broken. Look about right though, didn't seem too hard to add. |
|
Code looks good, I'll test it in the morning to make sure it works before submitting a review. |
|
Sounds good! I'll force push with signed commits because I don't like seeing unverified. Hopefully I can get those up tonight. If not, I wouldn't recommend testing until I force push the signed commits, just in case anything went wrong with the force push :D |
sh0ckR6
force-pushed
the
issues/16-config-reset
branch
from
cf1f675 to
5572867
Compare
Added support for resetting s back to their defaults via
Add reloading/resetting configuration by object
Mark methods `static` that needed to be static
Support config resetting
|
of course I forgot a commit, let me try force pushing for a second time |
sh0ckR6
force-pushed
the
issues/16-config-reset
branch
from
5572867 to
0cc50be
Compare
|
there we are, all 5 commits signed! off to bed I go, this has been a confusing and chaotic past 2 hours -_- |
gtaEPIC
left a comment
gtaEPIC
left a comment
There was a problem hiding this comment.
An exception is thrown if no arguments are provided
src/main/java/com/github/sh0ckr6/achievementborder/commands/ConfigCommand.java
Show resolved
Hide resolved
|
Also, not quite sure if it was intended, but if you load a new map, the configurations need to be reset in order to have the logs spawn under the player when they join |
|
Yeah, I've noticed that when moving between the test world and my main world. Either you or I can open an issue for this as it's definitely not intentional. |
Add argument length checks for `handleReload` and `handleReset`
|
Updated PR with requested changes |
src/main/java/com/github/sh0ckr6/achievementborder/commands/ConfigCommand.java
Show resolved
Hide resolved
|
So turns out, this PR is completely broken. Configuration resetting just doesn't work at all (which is quite infuriating but that's fine) I'll have to look into why this isn't working |
2 participants
Add support for resetting configuration files via the
/configcommand.This repo hasn't been worked on for quite some time. I wanted to give this project the love it deserves, so I came back to it after a couple months of letting it sit.