Fix mojibake in error messages when .slang-module can't find source file #9147
+31
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using precompiled
.slang-modulefiles, error messages for missing imports displayed garbage characters (mojibake) instead of clean diagnostic output:Root cause:
IncludeSystem::loadFilecreates aSourceFilewith binary module content. When diagnostics are raised, the code finds this existing file and attempts to display "source lines" from binary data.Changes:
slang-session.cpp: Always create a fresh empty source file for binary module diagnostic locations instead of reusing one that may contain binary contentslang-diagnostic-sink.cpp: AddhasContent()guard in_sourceLocationNoteDiagnosticand_tokenLengthNoteDiagnosticto skip source line display when content isn't availableAfter fix:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.