Skip to content

Allow override keyword inside extension #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+29 −2
Open

Allow override keyword inside extension #9156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75fbc7
Allow override keyword inside extension
juliusikkala Nov 27, 2025
2bc26df
Fix formatting
juliusikkala Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/slang/slang-check-modifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1531,7 +1531,11 @@ bool isModifierAllowedOnDecl(bool isGLSLInput, ASTNodeType modifierType, Decl* d
case ASTNodeType::DynModifier:
return as<InterfaceDecl>(decl) || as<VarDecl>(decl) || as<ParamDecl>(decl);
case ASTNodeType::OverrideModifier:
return as<FunctionDeclBase>(decl) && as<AggTypeDecl>(getParentDecl(decl));
{
Decl* parent = getParentDecl(decl);
return as<FunctionDeclBase>(decl) &&
(as<AggTypeDecl>(parent) || as<ExtensionDecl>(parent));
}
default:
return true;
}
Expand Down
25 changes: 24 additions & 1 deletion tests/language-feature/interfaces/override-default-method.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,25 @@ struct Impl : IFoo
}
}

struct Other
{
int n;
}

extension Other: IFoo
{
int getVal()
{
return n;
}

// Override should also work inside an extension
override int getGreaterVal<int x>()
{
return getVal() + x + 2;
}
}

int test<T:IFoo>(T v) { return v.getGreaterVal<1>(); }

//TEST_INPUT: set resultBuffer = out ubuffer(data=[0 0 0 0], stride=4)
Expand All @@ -37,4 +56,8 @@ void computeMain()
int result = test(impl);
resultBuffer[0] = result;
// CHECK: 44
}

Other other = {32};
resultBuffer[1] = test(other);
// CHECK-NEXT: 35
}