Added code that ensures SlangSession does not return 2 different SlangModules for one slang::IModule. #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gModules for one slang::IModule.
Collaborator
Author
|
Add tests, and add to load_from_file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the Module deduplication happens only on the Slang level. That is, Slang will return the same
slang::IModuleobject for a duplicate request.This PR propagates this up to sgl::SlangSession and ensures that if SlangSession will return only one SlangModule for each slang::IModule. This is achieved by first creating SlangModule and then deduplicating based on the
slang::IModulethesgl::SlangModulecontains. This is slightly less efficient than checking the inputs directly, but it strictly defers to the way Slang handles its deduplication.