Skip to content

fix: downgrade cryptography version to 45.0.3#10

Merged
shaiu merged 1 commit intodevfrom
cryptography-downgrade
Jun 21, 2025
Merged

fix: downgrade cryptography version to 45.0.3#10
shaiu merged 1 commit intodevfrom
cryptography-downgrade

Conversation

@shaiu
Copy link
Copy Markdown
Owner

@shaiu shaiu commented Jun 21, 2025

Describe what the PR does:

downgrade cryptography version to 45.0.3

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @shaiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a dependency constraint by downgrading the required cryptography package version to 45.0.3. This change is reflected across the project's primary dependency management files and is accompanied by a minor version bump for the project itself, likely indicating a bug fix or minor adjustment related to this dependency change.

Highlights

  • Dependency Downgrade: The cryptography dependency has been explicitly downgraded to version 45.0.3 in both pyproject.toml and requirements_test.txt.
  • Project Version Bump: The project's own version has been incremented from 1.1.0 to 1.1.1 in pyproject.toml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses the stated goal of downgrading the cryptography dependency to version 45.0.3 across pyproject.toml and requirements_test.txt. The version bump for the project itself is also appropriate for a patch release.

Comment thread pyproject.toml
python = "^3.9.0"
pytz = ">=2021.1"
cryptography = ">=45.0.4"
cryptography = ">=45.0.3"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Downgrading a critical dependency like cryptography can have significant implications. The pull request description is very brief. It's crucial to document the specific reason for this downgrade (e.g., a known bug in 45.0.4, incompatibility with other dependencies, etc.) to ensure future maintainers understand the context and potential risks. This information should ideally be in the PR description or as a comment within the pyproject.toml file itself (e.g., cryptography = ">=45.0.3" # Reason: [Explain here]).

Comment thread pyproject.toml
python = "^3.9.0"
pytz = ">=2021.1"
cryptography = ">=45.0.4"
cryptography = ">=45.0.3"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change from cryptography = ">=45.0.4" to cryptography = ">=45.0.3" still allows for 45.0.4 or newer versions to be installed if they are released and poetry resolves them. If the downgrade is specifically to avoid a problem in 45.0.4, it might be safer to strictly pin the version to ==45.0.3 instead of >=45.0.3. This prevents poetry from potentially installing 45.0.4 or any future problematic versions that might re-introduce the problem, ensuring the stability of the dependency.

cryptography = "==45.0.3"

@shaiu shaiu merged commit 75cf6d6 into dev Jun 21, 2025
7 checks passed
@shaiu shaiu deleted the cryptography-downgrade branch June 22, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant