fix: handle null API responses and add debug logging#15
Conversation
- Guard against null summary_resp and packages_resp (and their Json field)
to fix AttributeError when 17track returns {"Json": null}
- Add debug logging in _request for HTTP status, content-type, and raw body
- Add warning log when JSON parsing returns None
- Bump version to 1.1.2
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the robustness of the 17track.net API client by implementing comprehensive null checks for API responses, preventing potential Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses potential AttributeError exceptions from null API responses and adds valuable debug logging, improving the robustness of the client. No security vulnerabilities were found. My review includes suggestions to enhance type safety and improve code readability, especially for complex null-checking expressions, to improve maintainability.
| resp.raise_for_status() | ||
| raw: str = await resp.text() | ||
| _LOGGER.debug("Raw response body from %s: %r", url, raw) | ||
| data: dict = await resp.json(content_type=None) |
There was a problem hiding this comment.
The type hint for data is dict, but resp.json() can return None, as you correctly check on the following lines. This creates a type inconsistency. To fix this, the type hint for data should be Optional[dict].
Additionally, the return type hint for the _request function (on line 38) should be updated from -> dict to -> Optional[dict] to accurately reflect that it can return None.
| data: dict = await resp.json(content_type=None) | |
| data: Optional[dict] = await resp.json(content_type=None) |
|
|
||
| packages: List[Package] = [] | ||
| for package in packages_resp.get("Json", []): | ||
| for package in (packages_resp or {}).get("Json") or []: |
There was a problem hiding this comment.
While this line correctly handles potential None values, its density can make it difficult to read and understand at a glance. For better readability and maintainability, consider extracting the package list into a separate variable before the loop.
For example:
package_list = (packages_resp or {}).get("Json") or []
for package in package_list:|
|
||
| results: dict = {} | ||
| for kind in summary_resp.get("Json", {}).get("eitem", []): | ||
| for kind in ((summary_resp or {}).get("Json") or {}).get("eitem", []): |
There was a problem hiding this comment.
This line is very dense and hard to read due to the nested safe access patterns. To improve readability and maintainability, it would be better to break this down into multiple steps.
Consider refactoring it like this:
summary_json = (summary_resp or {}).get("Json") or {}
for kind in summary_json.get("eitem", []):1 participant
Describe what the PR does:
Checklist:
README.mdwith any new documentation.AUTHORS.md.