qa: add tests, CI, lint cleanup, security scanning, and PR template#11
Open
paragon-review[bot] wants to merge 1 commit intomainfrom
Open
qa: add tests, CI, lint cleanup, security scanning, and PR template#11paragon-review[bot] wants to merge 1 commit intomainfrom
paragon-review[bot] wants to merge 1 commit intomainfrom
Conversation
- Remove 9 stale eslint-disable-next-line comments from Home, Intouch, Palkia, PillThought; bun run lint now reports 0 issues - Install Vitest, @testing-library/react, jsdom and configure via vite.config.ts (globals, jsdom environment, v8 coverage) - Add src/test-setup.ts for jest-dom matchers - Add App.test.tsx: 4 routing tests covering all defined routes - Add Home.test.tsx: 7 component tests covering heading, social links, image rendering, and navigation callbacks - Add test/typecheck/coverage scripts to package.json - Pin vite to 6.4.1 to resolve GHSA-vg6x-rcgg and related CVEs; reduce audit findings from 30 to 13 (all remaining are transitive, see PR body for details) - Add .github/PULL_REQUEST_TEMPLATE.md with QA checklist Verification: bun run lint -- 0 issues bun run typecheck -- 0 errors bun run test -- 11/11 passed (2 test files) bun run build -- success semgrep --config auto -- 0 findings paragon-assisted
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR establishes comprehensive QA infrastructure for the portfolio project.
paragon-assisted
What Changed
1. Lint Cleanup
Removed 9 stale
eslint-disable-next-line no-consoledirectives fromHome.tsx,Intouch.tsx,Palkia.tsx, andPillThought.tsx.bun run lintnow reports 0 issues.2. Automated Tests (Vitest)
vitest,@vitest/coverage-v8,@testing-library/react,@testing-library/jest-dom,jsdomvite.config.tswith jsdom environment and v8 coveragesrc/test-setup.tsfor jest-dom matchers/,/intouchcx,/pillthought,/palkia)3. New npm Scripts
4. Dependency Update
Pinned
viteto6.4.1to resolve:Audit findings reduced from 30 to 13. Remaining 13 are all transitive dev-only dependencies with no direct remediation path:
| Package | Severity | Advisory |
|---------|----------|---------|
| flatted <3.4.0 | High | GHSA-25h7-pfq9-p65f, GHSA-rf6f-7fwh-wjgh (via eslint) |
| rollup >=4.0.0 <4.59.0 | High | GHSA-mw96-cpmx-2vgc (via vite, dev-only) |
| picomatch <2.3.2 | High | GHSA-c2c7-rcm5-vvqj (via vite/vitest/tailwindcss, dev-only) |
| minimatch | High | GHSA-3ppc-4f35-3m26 (via eslint, dev-only) |
| glob | High | GHSA-7r86-cg39-jmmj (via eslint, dev-only) |
| esbuild <=0.24.2 | Moderate | GHSA-67mh-4wv8-2f99 (via vite, dev-only) |
| yaml <2.8.3 | Moderate | GHSA-48c2-rrv3-qjmp (via vite/tailwindcss, dev-only) |
| ajv <6.14.0 | Moderate | GHSA-v72f-d9hq-688g (via eslint, dev-only) |
| @babel/helpers <7.26.10 | Moderate | GHSA-968p-4wvh-cqc8 (via @vitejs/plugin-react, dev-only) |
All remaining issues are in the dev toolchain (not shipped in production bundles).
5. PR Template
Added
.github/PULL_REQUEST_TEMPLATE.mdwith a QA checklist (lint, typecheck, test, build, audit).6. CI Workflows (manual step required)
The GitHub App used by Paragon lacks the
workflowspermission, so workflow files could not be pushed directly. Copy these files manually to add CI:.github/workflows/ci.yml— runs on push/PR to main:.github/workflows/security.yml— runs on push/PR/weekly schedule:Semgrep SAST
semgrep --config auto my-portfolio/src/ --severity ERROR --severity WARNINGResult: 0 findings (clean baseline)
Verification