fix: add missing SND_SYNC flag to winsound.PlaySound to prevent sounds being cut off on Windows#53
Open
kuishou68 wants to merge 1 commit intoshanraisshan:mainfrom
Open
Conversation
…nraisshan#52) Signed-off-by: cocoon <54054995+kuishou68@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52
Problem
In
.claude/hooks/scripts/hooks.py, theplay_sound()function callswinsound.PlaySoundwithoutSND_SYNC. The code comment explicitly statesSND_SYNCshould be used to ensure synchronous playback, but the flag is missing. Without it,winsound.PlaySounddefaults to async mode and the sound is cut off when the script exits.Fix
Add
winsound.SND_SYNCto the flags passed towinsound.PlaySound:Signed-off-by: cocoon 54054995+kuishou68@users.noreply.github.com