Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ VITE_FEATURE_HYPEREVM=true
VITE_FEATURE_MANTLE=false
VITE_FEATURE_INK=false
VITE_FEATURE_CRONOS=false
VITE_FEATURE_MEGAETH=false
VITE_FEATURE_MEGAETH=true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check if VITE_FEATURE_MEGAETH is defined in mode-specific .env files

echo "Checking for VITE_FEATURE_MEGAETH in mode-specific .env files..."
fd -t f '^\.env\.(development|production)$' --exec grep -H 'VITE_FEATURE_MEGAETH' {}

Repository: shapeshift/web

Length of output: 347


🏁 Script executed:

#!/bin/bash
# Check for VITE_FEATURE_MEGAETH in mode-specific .env files (with -H flag for hidden files)

echo "Checking for VITE_FEATURE_MEGAETH in mode-specific .env files..."
grep -r 'VITE_FEATURE_MEGAETH' .env.development .env.production 2>/dev/null || echo "No overrides found"

echo ""
echo "Listing available .env files:"
find . -maxdepth 1 -name '.env*' -type f | sort

Repository: shapeshift/web

Length of output: 267


Remove VITE_FEATURE_MEGAETH from .env.development to follow the global feature flag convention.

The change at line 329 in the base .env correctly enables MegaETH globally. However, .env.development also defines VITE_FEATURE_MEGAETH=true. When a feature flag is enabled globally in the base .env, the convention in this project is to remove it from mode-specific environment files to prevent configuration fragmentation. Remove the flag from .env.development to complete the global enablement.

🧰 Tools
🪛 dotenv-linter (4.0.0)

[warning] 329-329: [UnorderedKey] The VITE_FEATURE_MEGAETH key should go before the VITE_FEATURE_MONAD key

(UnorderedKey)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.env at line 329, Remove the duplicate feature flag VITE_FEATURE_MEGAETH
from the mode-specific environment file so it’s only defined globally in the
base .env; locate the VITE_FEATURE_MEGAETH entry in the development env file
(the mode-specific env that mirrors base .env) and delete that line, leaving the
single global definition intact.

VITE_FEATURE_LINEA=false
VITE_FEATURE_BERACHAIN=false
VITE_FEATURE_SCROLL=false
Expand Down