Skip to content

Fix test failures #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
scymtym wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix test failures #7

scymtym wants to merge 4 commits into from

Conversation

@scymtym
Copy link
Member

@scymtym scymtym commented Feb 25, 2020

  • text.serialize

  • element.base-uri

  • element.copy.7

  • element.add-extra-namespace.4

@scymtym
In TEXT.SERIALIZE test, do not expect " for "
a691517 
In 2008, commit 4c11d5b68a3e4532a282dc63e9c6301b586c74a0, cxml stopped
escaping double quotes using the " entity in text nodes.
@scymtym
In test ELEMENT.BASE-URI, do not expected BASE-URI to return an URIah
588183d 
As far as I can tell, I has always returned a string.
@scymtym
MAKE-ELEMENT coerces the element name to a ROD
df90860 
In particular, if the supplied name is a BASE-STRING, it is not of
type ROD without coercion.

This change makes test the ELEMENT.COPY.7 pass on SBCL. It failed
because

  (format nil "e~D" i)

returns a SIMPLE-BASE-STRING on recent SBCL versions.
@scymtym
Fix failure of test ELEMENT.ADD-EXTRA-NAMESPACE.4
7c01dbe 
The test did not bind *CHECK-URI-SYNTAX* to true.
@scymtym scymtym requested a review from slyrus February 25, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slyrus slyrus Awaiting requested review from slyrus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scymtym