Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/McpServer.Services/Ingestion/RepoIngestor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,9 @@ private static async IAsyncEnumerable<string> EnumerateAllFilesAsync(
{
cancellationToken.ThrowIfCancellationRequested();
var name = Path.GetFileName(path);
var relativePath = Path.GetRelativePath(dir, path);
if (name.StartsWith('.') || name == "mcp.db" ||
path.Contains("bin", StringComparison.Ordinal) || path.Contains("obj", StringComparison.Ordinal))
IsBuildArtifactPath(relativePath))
{
continue;
}
Expand All @@ -133,6 +134,16 @@ private static async IAsyncEnumerable<string> EnumerateAllFilesAsync(
await Task.CompletedTask.ConfigureAwait(false);
}

private static bool IsBuildArtifactPath(string relativePath)
{
var segments = relativePath
.Split(new[] { '/', '\\' }, StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries);

return segments.Any(static segment =>
segment.Equals("bin", StringComparison.OrdinalIgnoreCase) ||
segment.Equals("obj", StringComparison.OrdinalIgnoreCase));
}

private static bool MatchesAllowlist(string relativePath, IReadOnlyList<string> patterns)
{
var normalizedPath = relativePath.Replace('\\', '/');
Expand Down
13 changes: 12 additions & 1 deletion src/McpServer.Support.Mcp/Ingestion/RepoIngestor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,9 @@ private static async IAsyncEnumerable<string> EnumerateAllFilesAsync(
{
cancellationToken.ThrowIfCancellationRequested();
var name = Path.GetFileName(path);
var relativePath = Path.GetRelativePath(dir, path);
if (name.StartsWith('.') || name == "mcp.db" ||
path.Contains("bin", StringComparison.Ordinal) || path.Contains("obj", StringComparison.Ordinal))
IsBuildArtifactPath(relativePath))
{
continue;
}
Expand All @@ -133,6 +134,16 @@ private static async IAsyncEnumerable<string> EnumerateAllFilesAsync(
await Task.CompletedTask.ConfigureAwait(false);
}

private static bool IsBuildArtifactPath(string relativePath)
{
var segments = relativePath
.Split(new[] { '/', '\\' }, StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries);

return segments.Any(static segment =>
segment.Equals("bin", StringComparison.OrdinalIgnoreCase) ||
segment.Equals("obj", StringComparison.OrdinalIgnoreCase));
}

private static bool MatchesAllowlist(string relativePath, IReadOnlyList<string> patterns)
{
var normalizedPath = relativePath.Replace('\\', '/');
Expand Down
27 changes: 21 additions & 6 deletions tests/McpServer.Support.Mcp.Tests/Ingestion/RepoIngestorTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ public async Task IngestAsync_ContentHash_DeterministicForSameContent()
}

[Fact]
public async Task IngestAsync_SkipsLargeFiles()
{
public async Task IngestAsync_SkipsLargeFiles()
{
var largeContent = new string('x', 2 * 1024 * 1024); // 2MB
File.WriteAllText(Path.Combine(_tempDir, "large.txt"), largeContent);
File.WriteAllText(Path.Combine(_tempDir, "small.txt"), "small");
Expand All @@ -105,7 +105,22 @@ public async Task IngestAsync_SkipsLargeFiles()

var results = await sut.IngestAsync().ConfigureAwait(true);

Assert.DoesNotContain(results, r => r.Doc.SourceKey.Contains("large.txt"));
Assert.Contains(results, r => r.Doc.SourceKey.Contains("small.txt"));
}
}
Assert.DoesNotContain(results, r => r.Doc.SourceKey.Contains("large.txt"));
Assert.Contains(results, r => r.Doc.SourceKey.Contains("small.txt"));
}

[Fact]
public async Task IngestAsync_DoesNotSkipPathsThatContainBinOrObjAsSubstring()
{
var folderWithSubstring = Path.Combine(_tempDir, "binary-assets");
Directory.CreateDirectory(folderWithSubstring);
File.WriteAllText(Path.Combine(folderWithSubstring, "keep.md"), "# keep");

var options = Microsoft.Extensions.Options.Options.Create(new IngestionOptions { RepoRoot = _tempDir });
var sut = new RepoIngestor(new Chunker(), options, new WorkspaceContext(), NullLogger<RepoIngestor>.Instance);

var results = await sut.IngestAsync().ConfigureAwait(true);

Assert.Contains(results, r => r.Doc.SourceKey.Equals("binary-assets/keep.md", StringComparison.Ordinal));
}
}
Loading