Allow all react versions greater than 15.0.0 for peer deps#5
Open
cmdcolin wants to merge 1 commit intoshauns:masterfrom
Open
Allow all react versions greater than 15.0.0 for peer deps#5cmdcolin wants to merge 1 commit intoshauns:masterfrom
cmdcolin wants to merge 1 commit intoshauns:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Just wanted to say I'm really grateful for this library!
This PR proposes accepting all versions of react greater than 15 rather than only in the 15 major version range
That is pretty lenient but given the stability of react I think it is probably ok, and avoids warnings during install about missing peer deps from yarn and npm