Fix practice mode finish messages#1267
Merged
rtldg merged 4 commits intoshavitush:masterfrom Mar 8, 2026
Merged
Conversation
- Practice Mode:
- Added `PracticeBetterTime` phrase to show negative diff in Red when beating PB.
- Added logic to show positive diff in White when executing slower than PB.
- Added fallback to WR comparison if player has no PB.
- First Completion (No PB):
- Added `FirstCompletionBetter` and `FirstCompletionWorse` phrases.
- Now displays time difference relative to the Map Record (WR).
- Shows `(-)` in Red if faster than WR, `(+)` in White if slower.
- World Record Updates:
- When a player beats the WR (and it's not their first completion), the time difference is now calculated relative to the *Previous World Record*, not their Personal Best.
- Spectators:
- Fixed spectator messages to exactly match the player's message, ensuring correct formatting and colors are relayed.
Spectators watching a player who finished with a worse time were
receiving the second-person "WorseTime" phrase ("You have finished...")
in the client's language instead of a third-person message in their
own language.
Now, in the ranked worse-time case, each spectator receives a
separately formatted "NotFirstCompletionWorse" message translated
to their own language, showing the player's name in third person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PracticeBetterTimephrase to show negative diff in Red when beating PB.FirstCompletionBetterandFirstCompletionWorsephrases.(-)in Red if faster than WR,(+)in White if slower.