Conversation
- Add GDMASettings pydantic model - Add GDMAGenerator abstract base class
- Jinja2 template for generating Psi4 input files
- Add MPFITObjective and MPFITObjectiveTerm classes - Inherit from openff-recharge base classes
- Add MPFITSolver base class - Add IterativeSolver, SciPySolver, MPFITSVDSolver implementations
- Add generate_mpfit_charge_parameter function - Add molecule_to_mpfit_library_charge helper - Update mpfit __init__.py to export public API
- Change imports from openff.recharge to openff_pympfit for MPFIT/GDMA modules - Keep openff-recharge imports for library charges and utilities
- adopted atomate2 ruff config
- added furo theme - added intro, install, and tutorials section - added theory section for gdma and mpfit
Owner
|
Austin, excellent, this will be an awesome feature!! Two quick points
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Add MBIS Psi4 Support to pympfit
This PR implements Minimal Basis Iterative Stockholder (MBIS) charge calculation support in pympfit, providing an alternative to Gaussian Distributed Multipole Analysis (GDMA) for computing partial atomic charges from quantum chemistry calculations. The goals here attempt to address requested enhancements from issue#1.
Key Features Implemented
Core MBIS Infrastructure:
pympfit/mbis/_mbis.py: BaseMBISSettingsandMBISGeneratorclasses following the GDMA patternpympfit/data/psi4/mbis.dat: Jinja2 template for Psi4 MBIS calculations supporting multipoles up to octupoles (l=0-3)pympfit/mbis/psi4.py:Psi4MBISGeneratorclass for executing MBIS calculations via Psi4pympfit/mbis/storage/_storage.py:MoleculeMBISRecordandMoleculeMBISStoreclasses for SQLite-backed storageMultipole Transformation Utilities:
pympfit/mbis/multipole_transform.py: Comprehensive conversion between Cartesian (MBIS Psi4 native) and spherical harmonic (MPFIT-compatible) representations for dipoles, quadrupoles, and octupolespympfit/mbis/evaluate_cartesian_multipoles.py: Functions to compute electrostatic interaction energies using Cartesian multipole expansionsMPFIT Integration:
multipole_formatsettingStatus vs. Original Issue#1 Requirements
✅ Completed:
input.dattemplate for MBIS (pympfit/data/psi4/mbis.dat)MBISSettingsandMBISGeneratorclasses (mirrors GDMA implementation)MoleculeMBISRecordandMoleculeMBISStorefor SQLite backendPsi4MBISGeneratorMPFITObjective/MPFITSolverAdditional Enhancements:
pympfit/__init__.pySummary
This implementation enables users to benchmark MBIS vs. GDMA charges and leverage Psi4's native MBIS capabilities within the pympfit framework for high-throughput force field parameterization.