fix(raf-state): accumulate updates passed between repaints#12
Merged
vikiboss merged 1 commit intosheinsight:mainfrom Jan 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in useRafState where multiple function updates (e.g., setState(prev => prev + 1)) scheduled between repaint cycles would not accumulate properly, with only the last update being executed. The fix introduces state accumulation logic using a ref to track intermediate state changes.
Changes:
- Modified
useRafStateto accumulate state updates in a ref between repaints, ensuring all functional updates are applied correctly - Refactored tests into parameterized test cases covering value updates, function updates, and mixed updates
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react-use/src/use-raf-state/index.ts | Added ref-based accumulation logic with new imports (useCallback, useRef, isFunction) and custom setter callback to properly chain functional updates |
| packages/react-use/src/use-raf-state/index.test.ts | Converted multiple update tests into parameterized test suite with three scenarios (value, function, and mixed updates) to verify accumulation behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, updates scheduled via
useRafStateare deferred to the next frame, canceling previously scheduled update. If multiple function updates (e.g.setState(prev => prev + 1)) occur between repaint cycles, only the last update is executed, and previous intermediate state transitions are lost.In the demo, the
doublecallback should increment the counter twice by callingsetCount((v) => v + 1)two times. However, only the last call is actually executed on the repaint, so instead of resulting in+2, it results in+1.What was changed
useRafStateto accumulate state changes and only set the final state value on repaint (next frame)