Skip to content

Conversation

Barthelemy
Copy link

@Barthelemy Barthelemy commented Apr 16, 2025

fix #88

@shellfly
Copy link
Owner

@Barthelemy, thanks for the PR. Based on the document, it needs a migration to rename the index. Could you add it as well?
Also, please update the CI config to include tests for Django 5.2

@Barthelemy
Copy link
Author

Thanks for the comment. I did not realize that the migration should be part of the PR, sorry about that.
I will also update the CI config.

@Barthelemy
Copy link
Author

I have added the migration that Django generated. I am not sure why there is the AlterField though.

@shellfly
Copy link
Owner

I have added the migration that Django generated. I am not sure why there is the AlterField though.

It's probably related to this change. Could you set DEFAULT_AUTO_FIELD before generating the migration so that the migration is clean for this PR

@Barthelemy
Copy link
Author

Things are never as simple as we thought...

Given that the django versions still supported are 4.2, 5.1 and 5.2 I would propose to keep only the support for 4.2.20, 5.1.9, 5.2.1. RenameIndex was introduced in 4.1.
However that might not be what you want ?

@shellfly
Copy link
Owner

shellfly commented May 3, 2025

@Barthelemy, please go ahead and update the supported versions. Users can always use the previous tag version if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Django 5.2
2 participants