-
Notifications
You must be signed in to change notification settings - Fork 1
AB#12754 Carousel bg videos #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| --signin-sso-btn-background-color: var(--button-background); | ||
| --signin-sso-btn-background-hover-color: var(--button-background-hover); | ||
|
|
||
| // Carousel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in terms of rollout, we'd have to think about if we'd want to make changes to the default carousel height for all clients, or leave it the same and remember to adjust for each particular client. It likely would result in better carousel image though making less tall on mobile. more testing required to make sure all elements can fit if they are using all the things and have long film names etc.
|
note to self: fix up css lint issues |
|
its still a little messy, but if you have time for a quick pass i can make some fixes over the holiday break as a filler task. otherwise ill attempt to clean it up. |
…hange, update icons, move mute into cta buttons
|
cleaned up substantially. moved mute button into the CTAs as with other features couldnt find a good placement. it also goes alongside the existing trailer button. using event listeners now instead of mutation observer. |
sam-shift72
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description of work
Ability to use ingested trailers as background videos in the carousel. Currently if a film has an ingested trailer, and also has the custom field "use_trailer_as_background_video" set to true, then it will load the trailer into the background in the carousel. On page load it will load / play the first trailer if is there. Subsequent carousel items will load and play their trailer as they become visible if enabled (this is done via the mutation observer using changes to the class on the carousel items to determine which one is "current". Trailers will pause if carousel changes slides or if the trailer is popped open, and resume when visible again.
Controls - at the moment there are two buttons - mute / unmute the background video and pop open the trailer which is just reskinned version of the default trailer button. After thought / discussion makes me think we may not need these but i left them in for now. IF we decide to leave them in then will need feedback on the icons and placement, especially for mobile.
Resolution - currently using object-fit cover to fill the carousel area to the height set on the carousel via existing variable. seems to work pretty good so i havent played around with it much, potentially some improvements here. on the poc i did change the carousel height variables so the carousel increases in height from mobile to desktop to ensure the aspect of the video is somewhat respected.
Config settings/Toggles required for the feature to work
Affected Clients
Checklist