Disable wishlist infinite scroll to fix jank when deleting items #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something about the infinite scroll hack was breaking dynamic sliders when items were removed after the slider had been scrolled. This is still not ideal because the slider scroll position seems to reset, but I think that's a Relish bug caused by the way it updates the list of partials.
sam-shift72
commented
Dec 1, 2024
Contributor
Author
There was a problem hiding this comment.
Refactored this file to match what I did on continue_watching when I originally copypasta'd this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something about the infinite scroll hack was breaking dynamic sliders when items were removed after the slider had been scrolled.
This is still not ideal because the slider scroll position seems to reset, but I think that's a Relish bug caused by the way it updates the list of partials.
Checklist