-
Notifications
You must be signed in to change notification settings - Fork 1
prep release 1.9.21 #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
prep release 1.9.21 #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a -5px margin being added to the first child of a slider or collection in order to counter-style the padding and align it with titles -- except this looks goofy when it wraps because the posters don't line up in a grid. Instead, this applies the negative margin to the whole container.
It gets too w i d e on big screens and looks silly.
The overall size isn't changed, but it moves the text closer to the poster.
prepare release 1.9.20
…use / play trailer on modal
Something about the infinite scroll hack was breaking dynamic sliders when items were removed after the slider had been scrolled. This is still not ideal because the slider scroll position seems to reset, but I think that's a Relish bug caused by the way it updates the list of partials.
Alignment fix ups for sliders/collections/library pages
Disable wishlist infinite scroll to fix jank when deleting items
gifting button on film page
…hange, update icons, move mute into cta buttons
AB#12754 Carousel bg videos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.