Film title images #572
Merged
Film title images #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0ud0gg
commented
Mar 12, 2025
l0ud0gg
commented
Mar 12, 2025
Kazetsukai
reviewed
Mar 19, 2025
…fied to something else with element argument
Kazetsukai
approved these changes
Mar 26, 2025
Contributor
Kazetsukai
left a comment
Kazetsukai
left a comment
There was a problem hiding this comment.
Looks good to me (with the kibble.json changes not committed)
…images have a shadow
…to film-title-images
Contributor
Author
|
@sam-shift72 Complete for an initial Feature. Css vars and custom image type sizing will allow for some flexibility. Will look to merge next week unless you have more feedback / suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses existing custom image type for films so that a title image can be added into admin for upload with the other images.
Create a generic title jet so i can be used both on the carousel and detail page. this will load in the image if it exists, else just use the existing heading.
Sets image as fixed width with a max height in an attempt to keep it within a desirable location. The custom image types are defined per site in uber, so have set these as variables to allow for simplifying some flexibility if for some reason a client had a custom size to display.
Looking at custom image type support for film, there would be some substantial work to extend this to pages / tv etc, so scope is just for films at the moment.
Initial PR for feedback / thoughts on where from here.