Fix CRLF line ending handling when processing markdown #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@l0ud0gg I wonder if this is the root cause of the issue you mentioned this morning about inconsistent linebreaks on pages.
I had pasted in a test page and it must have been saved with \r\n line endings (windows style). The markdown lib kibble uses has an open issue from 8 years ago about this -- it doesn't detect the paragraph breaks with CRLF endings and creates one big paragraph. It probably leaves the \r\n in the HTML though, and so depending on the CSS whitespace handling it might still draw a linebreak, but at the natural lineheight, not the
<p>spacing.