Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, I will try to implement a custom binding to a checkbox.
API:
where MyProperty was a bool and MyCommand was a ReactiveCommand.
The binding changes would be handled separate to the events (in theory), but exceptions should be propagated through the command rather than you managing the state of the checkbox yourself.
ReactiveCommand has a .ThrownExceptions property which is an observable stream of exceptions so you can handle those things separate to the actual command. If your error handling runs from that, it should make your code simpler. You just need to throw an exception from your command callback.