Tweaks to client generation #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenfin
force-pushed
the
client-tweaks
branch
from
7ea6795 to
f831edd
Compare
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The non-privileged cloud is the more useful one and should be shorter. Reverse the names. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
stephenfin
force-pushed
the
client-tweaks
branch
from
f831edd to
6f49eab
Compare
EmilienM
approved these changes
Mar 6, 2025
Contributor
|
In your PR, standalone_openshift becomes openshift, right? |
Contributor
|
why not calling is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnf, notpipstandalonebecomesstandalone-adminandstandalone_openshiftbecomesstandaloneI imagine the last one could be slightly contentious since it changes people's workflows, but it makes sense to have the most commonly used cloud have the shortest name.